nielm commented on a change in pull request #16960:
URL: https://github.com/apache/beam/pull/16960#discussion_r815351525
##########
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIOReadTest.java
##########
@@ -373,19 +379,12 @@ public void testReadMetrics() throws Exception {
any(ReadQueryUpdateTransactionOption.class)))
.thenReturn(Arrays.asList(fakePartition, fakePartition,
fakePartition));
when(mockBatchTx.execute(any(Partition.class)))
- .thenThrow(
Review comment:
It gets caught below - the try/catch block around pipeline.run().
The previous behaviour of SpannerIO.Read was to fail the pipeline completely
when Read threw an exception (in fact runners like Dataflow would retry the
bundle a few times first). This PR restores that original behaviour (whether or
not it is the ideal behaviour is another question!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
