chamikaramj commented on a change in pull request #16960:
URL: https://github.com/apache/beam/pull/16960#discussion_r815352048
##########
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIOReadTest.java
##########
@@ -373,19 +379,12 @@ public void testReadMetrics() throws Exception {
any(ReadQueryUpdateTransactionOption.class)))
.thenReturn(Arrays.asList(fakePartition, fakePartition,
fakePartition));
when(mockBatchTx.execute(any(Partition.class)))
- .thenThrow(
Review comment:
BTW previous behavior is correct. We should fail the work item for
non-retriable errors and such failures will usually be retried few times by the
runner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
