lostluck commented on pull request #17045: URL: https://github.com/apache/beam/pull/17045#issuecomment-1072921900
Daniel, Please do keep in mind We Should Not submit this with a manually changed generate pb.go file. The bot tagged you in after my review for some reason. On Fri, Mar 18, 2022, 7:09 PM Daniel Oliveira ***@***.***> wrote: > ***@***.**** approved this pull request. > > This looks good to me, with one small nit that I don't think is worth > blocking on. Let me know what you think of that suggestion and I can merge > after. > ------------------------------ > > In sdks/go/pkg/beam/core/funcx/fn.go > <https://github.com/apache/beam/pull/17045#discussion_r830423680>: > > > @@ -415,7 +432,7 @@ func SubReturns(list []ReturnParam, indices ...int) []ReturnParam { > } > > // The order of present parameters and return values must be as follows: > -// func(FnContext?, FnPane?, FnWindow?, FnEventTime?, FnType?, FnRTracker?, (FnValue, SideInput*)?, FnEmit*) (RetEventTime?, RetOutput?, RetError?) > +// func(FnContext?, FnPane?, FnWindow?, FnEventTime?, FnType?, FnRTracker?, FnBundleFinalization?, (FnValue, SideInput*)?, FnEmit*) (RetEventTime?, RetOutput?, RetError?) > > Nit: Personally I think BundleFinalization should come before the > RTracker, because the restriction is basically part of the main input so I > feel it should come right before the main input. Not something I'd block > on, just preference. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/17045#pullrequestreview-914956075>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADKDOFKXTQTJ7YXFCGYE4LDVAUZNNANCNFSM5QHNRCRA> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
