dpcollins-google commented on a change in pull request #17125:
URL: https://github.com/apache/beam/pull/17125#discussion_r831162632
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/internal/PerSubscriptionPartitionSdf.java
##########
@@ -61,8 +64,8 @@ public void teardown() {
}
@GetInitialWatermarkEstimatorState
- public Instant getInitialWatermarkState() {
- return Instant.EPOCH;
+ public Instant getInitialWatermarkState(@Timestamp Instant inputTs) {
Review comment:
This can be unit tested (i.e. that calling getInitialWatermarkState
returns its input) but testing the interaction between the two is a bit
challenging? I'll think about, but defer for later, how I could write an
integration test for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
