dpcollins-google commented on a change in pull request #17125:
URL: https://github.com/apache/beam/pull/17125#discussion_r831164045
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/internal/SubscribeTransform.java
##########
@@ -38,12 +39,16 @@
import org.apache.beam.sdk.transforms.splittabledofn.RestrictionTracker;
import org.apache.beam.sdk.values.PBegin;
import org.apache.beam.sdk.values.PCollection;
-import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Stopwatch;
-import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.math.LongMath;
import org.joda.time.Duration;
public class SubscribeTransform extends PTransform<PBegin,
PCollection<SequencedMessage>> {
private static final long MEBIBYTE = 1L << 20;
+ private static final long SOFT_MEMORY_LIMIT = 512 * MEBIBYTE;
Review comment:
It can't be a pipeline option if we want it to be static without
creating a cache for it templated on some key that is a unique pipeline
identifier; I think its better to leave as a constant for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
