lukecwik commented on pull request #17134: URL: https://github.com/apache/beam/pull/17134#issuecomment-1074452530
> > I would suggest sticking with `read/writeLongViaLocalBuffer` since read/write calls can depend on many layers of I/O before > > Maybe use a local byte[] for longs and read calls for everything else? That seems consistent with what DataInputStream did as well. It is difficult for me to say whether 4 reads will be cheaper than creating a byte array. I wish fixed length value types could go on the stack then this would be a no brainer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
