lukecwik commented on pull request #17134: URL: https://github.com/apache/beam/pull/17134#issuecomment-1074470245
> oh also, any thoughts on using the guava Longs, Ints, Shorts.fromBytes methods here? I wasn't sure what the stance on using the shaded guava generally in the core libraries was. This is totally fine to use shaded guava internally. Just don't expose the types on the API surface of things that are public. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
