ibzib commented on a change in pull request #17046:
URL: https://github.com/apache/beam/pull/17046#discussion_r832690786
##########
File path: .test-infra/dataproc/flink_cluster.sh
##########
@@ -133,7 +134,8 @@ function create_cluster() {
# Docker init action restarts yarn so we need to start yarn session after
this restart happens.
# This is why flink init action is invoked last.
- gcloud dataproc clusters create $CLUSTER_NAME --region=global
--num-workers=$num_dataproc_workers --initialization-actions
$DOCKER_INIT,$BEAM_INIT,$FLINK_INIT --metadata "${metadata}",
--image-version=$image_version --zone=$GCLOUD_ZONE --quiet
+ #--initialization-actions $DOCKER_INIT,$BEAM_INIT,$FLINK_INIT Older
initialization
Review comment:
I don't think we need any of these comments anymore.
##########
File path: .test-infra/jenkins/job_LoadTests_Combine_Flink_Go.groovy
##########
@@ -133,5 +133,5 @@
CronJobBuilder.cronJob('beam_LoadTests_Go_Combine_Flink_Batch', 'H 8 * * *', thi
influx_hostname: InfluxDBCredentialsHelper.InfluxDBHostUrl,
]
// TODO(BEAM-12898): Re-enable this test once fixed.
- // loadTestJob(delegate, CommonTestProperties.TriggeringContext.POST_COMMIT,
'batch')
+ //loadTestJob(delegate, CommonTestProperties.TriggeringContext.POST_COMMIT,
'batch')
Review comment:
We can re-enable these. It's fine if they're failing as long as we're
not leaking VMs (which I believe was fixed in #15547).
##########
File path: .test-infra/jenkins/CommonTestProperties.groovy
##########
@@ -26,7 +26,7 @@ class CommonTestProperties {
}
static String getFlinkVersion() {
- return "1.13"
+ return "1.12" //Flink Version in dataproc 2.0
Review comment:
I don't think this sets the Flink version used in the load tests. I
think that's set in each load test config, e.g.
https://github.com/apache/beam/blob/d3f320426a115b8c986a817fe2ba87f9fd7f2192/.test-infra/jenkins/job_LoadTests_GBK_Flink_Go.groovy#L201
Looks like it's already set to 1.12, so you can probably revert this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
