johnjcasey commented on a change in pull request #16923:
URL: https://github.com/apache/beam/pull/16923#discussion_r836577190
##########
File path:
runners/java-fn-execution/src/test/java/org/apache/beam/runners/fnexecution/wire/CommonCoderTest.java
##########
@@ -382,6 +384,17 @@ private static Object convertValue(Object value,
CommonCoder coderSpec, Coder co
Map<String, Object> kvMap = (Map<String, Object>) value;
Coder windowCoder = ((TimestampPrefixingWindowCoder)
coder).getWindowCoder();
return convertValue(kvMap.get("window"),
coderSpec.getComponents().get(0), windowCoder);
+ } else if (s.equals(getUrn(StandardCoders.Enum.NULLABLE))) {
Review comment:
It is a single test in the java sense, but there are 3 test cases in the
yaml file for nullable coders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
