johnjcasey commented on a change in pull request #16923:
URL: https://github.com/apache/beam/pull/16923#discussion_r837727045
##########
File path: sdks/python/apache_beam/typehints/typehints_test.py
##########
@@ -320,6 +320,14 @@ def test_getitem_proxy_to_union(self):
hint = typehints.Optional[int]
self.assertTrue(isinstance(hint, typehints.UnionHint.UnionConstraint))
+ def test_is_optional(self):
Review comment:
We are, Brian wrote them when NullableCoder was just used for nested
encoding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
