mosche commented on pull request #17172: URL: https://github.com/apache/beam/pull/17172#issuecomment-1081574040
I've pushed my [benchmark code ](https://github.com/apache/beam/pull/17203) for reference, let me know if you have any suggestions. To prevent the issue you've mentioned @reuvenlax, I'm setting up a relatively large number of rows as JMH state before the actual benchmark invocation. To establish a baseline, I'm looking at `master` first. [Here](https://jmh.morethan.io/?sources=https://raw.githubusercontent.com/apache/beam/3b5e1d607d30397abb27a119fc30c5d05a7b2d40/sdks/java/harness/jmh/RowWithGetters-master-cache-disabled.json,https://raw.githubusercontent.com/apache/beam/3b5e1d607d30397abb27a119fc30c5d05a7b2d40/sdks/java/harness/jmh/RowWithGetters-master-cache-enabled-lazy-init.json) are some initial results with some minimal changes to `RowWithGetters` to make these benchmarks meaningful: - Disable caching for the first run. - Change initialisation of the cache data structure to lazy init so associated costs are considered in the benchmark. These numbers are certainly not very much in favour of the status quo. I'm still iterating on improvements, but from what I've seen so far far there's lots that can be done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
