TheNeuralBit commented on a change in pull request #17043:
URL: https://github.com/apache/beam/pull/17043#discussion_r838926287
##########
File path: sdks/python/apache_beam/dataframe/pandas_doctests_test.py
##########
@@ -876,7 +869,7 @@ def test_top_level(self):
'merge_ordered(df1, df2, fill_method="ffill", left_by="group")'
],
# Expected error.
- 'pivot': ["df.pivot(index='foo', columns='bar', values='baz')"],
+ 'pivot': ["*"],
Review comment:
I don't think we want to skip all the pivot tests, can we revert this
line and instead add `'pivot': ["*"]` to wont_implement_ok (as suggested above).
##########
File path: sdks/python/apache_beam/dataframe/pandas_doctests_test.py
##########
@@ -366,9 +362,7 @@ def test_dataframe_tests(self):
# actually raise NotImplementedError
'pandas.core.frame.DataFrame.pivot_table': ['*'],
# Expected to raise a ValueError, but we raise NotImplementedError
- 'pandas.core.frame.DataFrame.pivot': [
- "df.pivot(index='foo', columns='bar', values='baz')"
- ],
Review comment:
Similarly here
##########
File path: sdks/python/apache_beam/dataframe/pandas_doctests_test.py
##########
@@ -832,7 +826,6 @@ def test_top_level(self):
'melt': ['*'],
'merge': ["df1.merge(df2, how='cross')"],
'merge_asof': ['*'],
- 'pivot': ['*'],
Review comment:
I think this should be wont_implement_ok instead, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
