[GitHub] [beam] TheNeuralBit commented on a change in pull request #17043: [BEAM-13966] Add pivot(), a non-deferred column operation on categorical columns

Wed, 30 Mar 2022 13:17:24 -0700 


TheNeuralBit commented on a change in pull request #17043:
URL: https://github.com/apache/beam/pull/17043#discussion_r838929290



##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -3655,6 +3656,109 @@ def shift(self, axis, freq, **kwargs):
   describe = _agg_method(pd.DataFrame, 'describe')
   max = _agg_method(pd.DataFrame, 'max')
   min = _agg_method(pd.DataFrame, 'min')
+
+  @frame_base.with_docs_from(pd.DataFrame)
+  @frame_base.args_to_kwargs(pd.DataFrame)
+  @frame_base.populate_defaults(pd.DataFrame)
+  def pivot(self, index=None, columns=None, values=None, **kwargs):

Review comment:
       Oh please also add a docstring here indicating that any columns 
specified in `columns` must have CategoricalDType so we can determine the 
output column names. There's docstring infrastructure that will put this 
message in the "Differences from pandas" section, e.g. for align: 
   
![image](https://user-images.githubusercontent.com/675055/160923353-f75e81b7-ea4b-48ee-8567-c78016799cdc.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to