KevinGG commented on a change in pull request #17127: URL: https://github.com/apache/beam/pull/17127#discussion_r839024480
########## File path: sdks/python/apache_beam/runners/interactive/extensions/apache-beam-jupyterlab-sidepanel/src/clusters/Clusters.tsx ########## @@ -0,0 +1,289 @@ +// Licensed under the Apache License, Version 2.0 (the 'License'); you may not +// use this file except in compliance with the License. You may obtain a copy of +// the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an 'AS IS' BASIS, WITHOUT +// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +// License for the specific language governing permissions and limitations under +// the License. + +import * as React from 'react'; + +import { ISessionContext } from '@jupyterlab/apputils'; + +import { Button } from '@rmwc/button'; +import { + DataTable, + DataTableContent, + DataTableRow, + DataTableHeadCell +} from '@rmwc/data-table'; + +import { + Dialog, + DialogTitle, + DialogContent, + DialogActions, + DialogButton +} from '@rmwc/dialog'; + +import { Fab } from '@rmwc/fab'; + +import { Select } from '@rmwc/select'; + +import { + TopAppBar, + TopAppBarFixedAdjust, + TopAppBarRow, + TopAppBarSection, + TopAppBarTitle +} from '@rmwc/top-app-bar'; + +import { KernelModel } from '../kernel/KernelModel'; + +import '@rmwc/button/styles'; +import '@rmwc/data-table/styles'; +import '@rmwc/dialog/styles'; +import '@rmwc/fab/styles'; +import '@rmwc/select/styles'; +import '@rmwc/top-app-bar/styles'; + +interface IClustersProps { + sessionContext: ISessionContext; +} + +interface IClustersState { + kernelDisplayName: string; + clusters: object; + defaultClusterId: string; + selectedId: string; + selectedName: string; + showDialog: boolean; + displayTable: boolean; +} + +/** + * This component is an interactive data-table that inspects Dataproc clusters + * managed by Apache Beam. + * + * The following user functionality is provided in this component: + * 1. View all Dataproc clusters managed by Interactive Beam + * 2. Delete a selected cluster. This will "reset" the cluster used by the + * corresponding pipelines and the cluster will be recreated when the + * pipeline is executed again. + * 3. Select a default cluster. This is the cluster that will be used by + * Interactive Beam when no master_url or Google Cloud project is + * specified in the pipeline options. + */ +export class Clusters extends React.Component<IClustersProps, IClustersState> { + constructor(props: IClustersProps) { + super(props); + this._inspectKernelCode = + 'from apache_beam.runners.interactive ' + + 'import interactive_environment as ie\n' + + 'ie.current_env().inspector.list_clusters()'; + this._model = new KernelModel(this.props.sessionContext); + this.state = { + kernelDisplayName: 'no kernel', + clusters: this._model.executeResult, + defaultClusterId: '', + selectedId: '', + selectedName: '', + showDialog: false, + displayTable: true + }; + } + + componentDidMount(): void { + this._queryKernelTimerId = setInterval( + () => this.queryKernel(this._inspectKernelCode), + 2000 + ); + this._updateRenderTimerId = setInterval(() => this.updateRender(), 1000); + this._updateSessionInfoTimerId = setInterval( + () => this.updateSessionInfo(), + 2000 + ); + } + + componentWillUnmount(): void { + clearInterval(this._queryKernelTimerId); + clearInterval(this._updateRenderTimerId); + clearInterval(this._updateSessionInfoTimerId); + } + + queryKernel(code: string): void { + this._model.execute(code); + } + + updateRender(): void { + const clustersToUpdate = this._model.executeResult; + if (Object.keys(clustersToUpdate).length) { + this.setState({ displayTable: true }); + if ( + JSON.stringify(this.state.clusters) !== JSON.stringify(clustersToUpdate) + ) { + this.setState({ clusters: clustersToUpdate }); + } + } + } + + updateSessionInfo(): void { + if (this.props.sessionContext) { + const newKernelDisplayName = this.props.sessionContext.kernelDisplayName; + if (newKernelDisplayName !== this.state.kernelDisplayName) { + this.setState({ + kernelDisplayName: newKernelDisplayName + }); + } + } + } + + setDefaultCluster(cluster_id: string): void { + const setDefaultClusterCode = + 'ie.current_env().clusters.set_default_cluster' + `('${cluster_id}')`; + this.queryKernel(setDefaultClusterCode); + this.setState({ defaultClusterId: cluster_id }); + } + + displayDialog(open: boolean, key: string, clusterName: string): void { + this.setState({ + showDialog: open, + selectedId: key, + selectedName: clusterName + }); + } + + deleteCluster(cluster_id: string): void { + const deleteClusterCode = + 'ie.current_env().clusters.delete_cluster' + `('${cluster_id}')`; Review comment: Can we change this from ``` 'ie.current_env().clusters.delete_cluster' + `('${cluster_id}')` ``` to ``` 'ie.current_env().clusters.delete_cluster' + `('ie.current_env().inspector.get_cluster_master(${cluster_id})')` ``` So in the inspector class, instead of ``` def get_cluster_data(self): return self._clusters ``` change it to ``` def get_cluster_data(self, id:str): return self._clusters[id] # The id is guaranteed to exist. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
