KevinGG commented on a change in pull request #17127:
URL: https://github.com/apache/beam/pull/17127#discussion_r839028953
##########
File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py
##########
@@ -443,6 +448,31 @@ def cleanup(
self.master_urls_to_pipelines.clear()
self.master_urls_to_dashboards.clear()
+ def delete_cluster(self, id: str):
Review comment:
Do not leak the obfuscated id from inspector to this module because it's
meaningless in other in-kernel modules.
See the comment for inspector for more details.
You can define this as
```
def delete_cluster(self, master: Union[str, MasterURLIdentifier]):
// get pipelines from self._master_urls_to_pipelines
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
