amuletxheart commented on a change in pull request #15485:
URL: https://github.com/apache/beam/pull/15485#discussion_r839077641
##########
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java
##########
@@ -2320,6 +2322,46 @@ public void testWriteToTableDecorator() throws Exception
{
p.run();
}
+ @Test
+ public void testWriteWithAllowTruncatedTimestamps() throws IOException,
InterruptedException {
+ if (useStorageApi) {
+ // TODO: to support storage API, changes have to be made to
+ // org.apache.beam.sdk.io.gcp.bigquery.BeamRowToStorageApiProto
+ return;
Review comment:
@TheNeuralBit I'm going to create the Jira ticket. What do you mean by
"fail gracefully"? Can you elaborate a little more, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
