amuletxheart commented on a change in pull request #15485:
URL: https://github.com/apache/beam/pull/15485#discussion_r839085893
##########
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java
##########
@@ -2320,6 +2322,46 @@ public void testWriteToTableDecorator() throws Exception
{
p.run();
}
+ @Test
+ public void testWriteWithAllowTruncatedTimestamps() throws IOException,
InterruptedException {
+ if (useStorageApi) {
+ // TODO: to support storage API, changes have to be made to
+ // org.apache.beam.sdk.io.gcp.bigquery.BeamRowToStorageApiProto
+ return;
Review comment:
@TheNeuralBit FYI this is the error that the test cases with
`useStorageApi = true` fails with:
`Caused by: java.lang.RuntimeException: Unsupported logical type LOGICAL_TYPE
at
org.apache.beam.sdk.io.gcp.bigquery.BeamRowToStorageApiProto.fieldDescriptorFromBeamField(BeamRowToStorageApiProto.java:224)
at
org.apache.beam.sdk.io.gcp.bigquery.BeamRowToStorageApiProto.descriptorSchemaFromBeamSchema(BeamRowToStorageApiProto.java:181)
at
org.apache.beam.sdk.io.gcp.bigquery.BeamRowToStorageApiProto.getDescriptorFromSchema(BeamRowToStorageApiProto.java:143)
at
org.apache.beam.sdk.io.gcp.bigquery.StorageApiDynamicDestinationsBeamRow$1.lambda$$0(StorageApiDynamicDestinationsBeamRow.java:54)
at
org.apache.beam.vendor.guava.v26_0_jre.com.google.common.cache.LocalCache$LocalManualCache$1.load(LocalCache.java:4876)
at
org.apache.beam.vendor.guava.v26_0_jre.com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3528)
at
org.apache.beam.vendor.guava.v26_0_jre.com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2277)
at
org.apache.beam.vendor.guava.v26_0_jre.com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2154)
at
org.apache.beam.vendor.guava.v26_0_jre.com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2044)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
