ryanthompson591 commented on code in PR #17368: URL: https://github.com/apache/beam/pull/17368#discussion_r851347805
########## sdks/python/apache_beam/ml/inference/sklearn_loader.py: ########## @@ -0,0 +1,73 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +import abc +import enum +import pickle +import sys +from dataclasses import dataclass +from typing import Any +from typing import Iterable +from typing import List + +import joblib +import numpy + +import apache_beam.ml.inference.api as api +import apache_beam.ml.inference.base as base +import sklearn_loader +from apache_beam.io.filesystems import FileSystems + + +class SerializationType(enum.Enum): + PICKLE = 1 + JOBLIB = 2 + + +class SKLearnInferenceRunner(base.InferenceRunner): Review Comment: Looking at sklearn in particular it is always lower case. Elsewhere in Beam we do have consecutive capitals like: PValue ReadFromTFRecord I think for PyTorch you should just follow what you think users would expect (WRT naming). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
