yeandy commented on code in PR #17368:
URL: https://github.com/apache/beam/pull/17368#discussion_r852194193
##########
sdks/python/apache_beam/ml/inference/sklearn_loader_test.py:
##########
@@ -151,6 +151,12 @@ def test_bad_file_raises(self):
SklearnModelLoader(model_uri='/var/bad_file_name'))
pipeline.run()
+ def test_bad_input_type_raises(self):
+ with tempfile.NamedTemporaryFile() as file:
+ with self.assertRaises(TypeError):
Review Comment:
just to be super clear that it's the custom error that you wrote, it might
be better to do `self.assertRaisesRegex(TypeError, 'Unsupported serialization
type.')`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
