egalpin commented on PR #17297: URL: https://github.com/apache/beam/pull/17297#issuecomment-1101856232
@nishantjain91 Overall this change looks good at the moment, thanks! The blocker now is that we need to determine the best structure for test suites. I think the best approach for now would be to include a test in each of the suites for each of the supported ES versions. The ES tests could do with restructuring overall, but I don’t think your PR should be blocked by that additional effort. So please add a case for this test in the suite of each supported version and then I feel we can merge. You may need to rebase on master as support for version 8.x of ES was recently added (which simultaneously dropped support for version 2.x of ES). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
