egalpin commented on PR #17297: URL: https://github.com/apache/beam/pull/17297#issuecomment-1118940186
This PR has been blocked on me, apologies for the slow review cadence. The next step would be to ideally find a way to write a test that "would have failed" with the code in master now, and would now pass as a result of @nishantjain91's great changes. That way we can guard against regressions in the future. I haven't had time to dig into what options there might be for inspecting the resulting `RestClient` object (or the effect of the fix on generated requests via the `RestClient`, which might also be a sufficient test). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
