RustedBones commented on PR #16271: URL: https://github.com/apache/beam/pull/16271#issuecomment-1113175873
I've addressed the last comments. Is there anything else you'd want to be improved ? I still think this is a relevant change to enable users to move to avro 1.9 if they want to. Then it is up to the maintainer to see if it is fine to: - drop the `timestamp-millis` logical type conversion on avro reflect (will require custom factories and coders). - Avro 1.9 users should manually add the Joda `DateTime` conversion since Beam's copy is removed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
