TheNeuralBit commented on code in PR #17384: URL: https://github.com/apache/beam/pull/17384#discussion_r863268400
########## sdks/python/apache_beam/transforms/combiners.py: ########## @@ -88,7 +90,7 @@ def expand(self, pcoll): # TODO(laolu): This type signature is overly restrictive. This should be # more general. -@with_input_types(Union[float, int]) +@with_input_types(Union[float, int, np.int64, np.float64]) Review Comment: Note I had to make this typehint change so I could use CombinePerKey in one of my tests. Is this alright? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
