ryanthompson591 commented on code in PR #17244: URL: https://github.com/apache/beam/pull/17244#discussion_r869260142
########## sdks/python/apache_beam/io/gcp/gcsfilesystem.py: ########## @@ -38,6 +40,15 @@ class GCSFileSystem(FileSystem): CHUNK_SIZE = gcsio.MAX_BATCH_OPERATION_SIZE # Chuck size in batch operations GCS_PREFIX = 'gs://' + def __init__(self, pipeline_options): + super().__init__(pipeline_options) + if isinstance(pipeline_options, PipelineOptions): + gcs_options = pipeline_options.view_as(GoogleCloudOptions) + impersonate_service_account = gcs_options.impersonate_service_account Review Comment: I think I need to have it here, otherwise when the impersonated service tries to upload to a shared directory it won't be able to. Since credentials is a global variable it's important I set impersonation beforehand. We can discuss a refactor, but for now, I can't get this to work otherwise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
