ryanthompson591 commented on code in PR #17244:
URL: https://github.com/apache/beam/pull/17244#discussion_r869262839


##########
sdks/python/apache_beam/runners/dataflow/internal/apiclient.py:
##########
@@ -557,6 +558,8 @@ def __init__(self, options, root_staging_location=None):
     if self.google_cloud_options.no_auth:
       credentials = None
     else:
+      set_impersonation_accounts(
+          self.google_cloud_options.impersonate_service_account)

Review Comment:
   yes, I found a point where the pipeline options are modified for job 
submission and modified it so that impersonation doesn't propegate to the 
workers.
   
   For anyone unfamiliar looking at this comment, the service worker that runs 
jobs in dataflow is unique and we don't want to try to do impersonation on the 
service worker, but rather only on the submission to dataflow.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to