diegomez17 commented on code in PR #16939:
URL: https://github.com/apache/beam/pull/16939#discussion_r871850455
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceImpl.java:
##########
@@ -320,6 +570,15 @@ public String toString() {
@Override
public Reader createReader(BigtableSource source) throws IOException {
+ BigtableSession session = new BigtableSession(options);
+ if (source.getMaxBufferElementCount() != null) {
+ return BigtableSegmentReaderImpl.create(session, source);
+ } else {
+ return new BigtableReaderImpl(session, source);
+ }
+ }
+
+ public Reader createSegmentReader(BigtableSource source) throws IOException {
BigtableSession session = new BigtableSession(options);
return new BigtableReaderImpl(session, source);
Review Comment:
Removed this function as the logic inside of createReader should route to
the segmentReader if maxBufferElement is set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
