diegomez17 commented on code in PR #16939:
URL: https://github.com/apache/beam/pull/16939#discussion_r872526462
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceImpl.java:
##########
@@ -216,29 +216,25 @@ public Row getCurrentRow() throws NoSuchElementException {
static class BigtableSegmentReaderImpl implements Reader {
private BigtableSession session;
- @Nullable ReadRowsRequest nextRequest;
- final Queue<Row> buffer = new ArrayDeque<>();
- final int segmentSize;
- final int refillSegmentWaterMark;
- final String tableId;
- final RowFilter filter;
- final long bufferByteLimit;
+ @Nullable private ReadRowsRequest nextRequest;
+ private final Queue<Row> buffer;
+ private final long refillSegmentWaterMark;
+ private final long maxSegmentByteSize;
private Future<UpstreamResults> future;
private Row currentRow;
- private final ServiceCallMetric serviceCallMetric;
- // private boolean upstreamResourcesExhausted;
+ private static ServiceCallMetric serviceCallMetric;
- static class UpstreamResults {
- final List<Row> rows;
- final @Nullable ReadRowsRequest nextRequest;
+ private static class UpstreamResults {
+ private final List<Row> rows;
+ private final @Nullable ReadRowsRequest nextRequest;
UpstreamResults(List<Row> rows, @Nullable ReadRowsRequest nextRequest) {
this.rows = rows;
this.nextRequest = nextRequest;
}
}
- static BigtableSegmentReaderImpl create(BigtableSession session,
BigtableSource source) {
+ public static BigtableSegmentReaderImpl create(BigtableSession session,
BigtableSource source) {
Review Comment:
No, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
