jrmccluskey commented on code in PR #17716:
URL: https://github.com/apache/beam/pull/17716#discussion_r877233735
##########
sdks/go/pkg/beam/core/runtime/exec/datasource.go:
##########
@@ -348,6 +348,18 @@ func (n *DataSource) makeEncodeElms() func([]*FullValue)
([][]byte, error) {
return encodeElms
}
+func getRTrackerFromRoot(root *FullValue) (sdf.BoundableRTracker, float64,
bool) {
+ tracker, ok :=
root.Elm.(*FullValue).Elm2.(*FullValue).Elm.(sdf.BoundableRTracker)
+ if !ok {
+ return nil, -1.0, false
+ }
+ size, ok := root.Elm2.(float64)
+ if !ok {
Review Comment:
Good point given that I had to write the thing out on a piece of paper to
get the type assertions right. Added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
