jrmccluskey commented on code in PR #17716:
URL: https://github.com/apache/beam/pull/17716#discussion_r877537731
##########
sdks/go/pkg/beam/core/runtime/exec/datasource.go:
##########
@@ -385,11 +396,16 @@ func (n *DataSource) Checkpoint() (SplitResult,
time.Duration, bool, error) {
if err != nil {
return SplitResult{}, -1 * time.Minute, false, err
}
+ if len(rs) == 0 {
+ return SplitResult{}, -1 * time.Minute, false, nil
Review Comment:
A no-residual return is indicative of a no-op split, which can happen. In a
checkpointing context we wouldn't necessarily expect it but it adds some
protection if a user schedules a bundle to resume that didn't have any work
left.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
