jrmccluskey commented on code in PR #17712:
URL: https://github.com/apache/beam/pull/17712#discussion_r878112839
##########
sdks/go/pkg/beam/io/textio/sdf.go:
##########
@@ -37,17 +37,21 @@ func init() {
// ReadSdf is a variation of Read implemented via SplittableDoFn. This should
// result in increased performance with runners that support splitting.
+//
+// Deprecated: Called directly by Read, use that instead.
func ReadSdf(s beam.Scope, glob string) beam.PCollection {
- s = s.Scope("textio.ReadSdf")
+ s = s.Scope("textio.Read")
Review Comment:
IIRC it becomes a sub-scope.
##########
sdks/go/pkg/beam/io/textio/sdf.go:
##########
@@ -37,17 +37,21 @@ func init() {
// ReadSdf is a variation of Read implemented via SplittableDoFn. This should
// result in increased performance with runners that support splitting.
+//
+// Deprecated: Called directly by Read, use that instead.
func ReadSdf(s beam.Scope, glob string) beam.PCollection {
- s = s.Scope("textio.ReadSdf")
+ s = s.Scope("textio.Read")
filesystem.ValidateScheme(glob)
return readSdf(s, beam.Create(s, glob))
}
// ReadAllSdf is a variation of ReadAll implemented via SplittableDoFn. This
// should result in increased performance with runners that support splitting.
+//
+// Deprecated: Called directly by ReadAll, use that instead.
func ReadAllSdf(s beam.Scope, col beam.PCollection) beam.PCollection {
- s = s.Scope("textio.ReadAllSdf")
+ s = s.Scope("textio.ReadAll")
Review Comment:
I agree, no reason to logically split it out if it's SDFs all the way down
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
