lostluck commented on code in PR #17712:
URL: https://github.com/apache/beam/pull/17712#discussion_r879919826
##########
sdks/go/pkg/beam/io/textio/sdf.go:
##########
@@ -37,17 +37,21 @@ func init() {
// ReadSdf is a variation of Read implemented via SplittableDoFn. This should
// result in increased performance with runners that support splitting.
+//
+// Deprecated: Called directly by Read, use that instead.
func ReadSdf(s beam.Scope, glob string) beam.PCollection {
- s = s.Scope("textio.ReadSdf")
+ s = s.Scope("textio.Read")
filesystem.ValidateScheme(glob)
return readSdf(s, beam.Create(s, glob))
}
// ReadAllSdf is a variation of ReadAll implemented via SplittableDoFn. This
// should result in increased performance with runners that support splitting.
+//
+// Deprecated: Called directly by ReadAll, use that instead.
func ReadAllSdf(s beam.Scope, col beam.PCollection) beam.PCollection {
- s = s.Scope("textio.ReadAllSdf")
+ s = s.Scope("textio.ReadAll")
Review Comment:
Agreed. Great call! Moved and ensured placement was reasonable, and dropped
vestigial SDFs that were no longer necessary (though added documentation that
they are SDFs and that they're useful for splitting within files.)
##########
sdks/go/pkg/beam/io/textio/sdf.go:
##########
@@ -37,17 +37,21 @@ func init() {
// ReadSdf is a variation of Read implemented via SplittableDoFn. This should
// result in increased performance with runners that support splitting.
+//
+// Deprecated: Called directly by Read, use that instead.
func ReadSdf(s beam.Scope, glob string) beam.PCollection {
- s = s.Scope("textio.ReadSdf")
+ s = s.Scope("textio.Read")
Review Comment:
Agreed it could be confusing, or breaking, so changed it to maintain scopes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
