jrmccluskey commented on code in PR #17724:
URL: https://github.com/apache/beam/pull/17724#discussion_r878372580
##########
sdks/go/pkg/beam/core/sdf/sdf.go:
##########
@@ -73,8 +73,8 @@ type RTracker interface {
// reason), then this function returns nil as the residual.
//
// If the split fraction is 0 (e.g. a self-checkpointing split)
TrySplit() should return either
- // a nil primary or an RTracker that is both bounded and has size 0.
This ensures that there is
- // no data that is lost by not being rescheduled for execution later.
+ // a nil primary or a restriction that represents no remaining work.
This will ensure that there
+ // is not data loss.
Review Comment:
So the returned primary restriction is supposed to be the same as the
restriction the RTracker holds as part of a typical runner-side split, so in
general we do care that the returns are configured correctly.
We do fail the pipeline to prevent the data loss, but I do prefer calling
out the why of failing the pipeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
