damccorm commented on code in PR #17724:
URL: https://github.com/apache/beam/pull/17724#discussion_r878410245
##########
sdks/go/pkg/beam/core/sdf/sdf.go:
##########
@@ -88,6 +89,8 @@ type RTracker interface {
// claimed. This method is called by the SDK Harness to validate that a
splittable DoFn has
// correctly processed all work in a restriction before finishing. If
this method still returns
// false after processing, then GetError is expected to return a
non-nil error.
+ //
+ // When called immediately following a checkpointing TrySplit() call,
this should return true.
Review Comment:
```suggestion
// When called immediately following a checkpointing TrySplit() call
(with value 0.0), this
// should return true.
```
##########
sdks/go/pkg/beam/core/sdf/sdf.go:
##########
@@ -73,8 +73,9 @@ type RTracker interface {
// reason), then this function returns nil as the residual.
//
// If the split fraction is 0 (e.g. a self-checkpointing split)
TrySplit() should return either
Review Comment:
```suggestion
// If the split fraction is 0 (e.g. a self-checkpointing split)
TrySplit() should return
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
