robertwb commented on code in PR #17762:
URL: https://github.com/apache/beam/pull/17762#discussion_r885923181
##########
sdks/python/apache_beam/ml/inference/base.py:
##########
@@ -54,17 +54,20 @@
_NANOSECOND_TO_MICROSECOND = 1000
_SECOND_TO_MICROSECOND = 1_000_000
-T = TypeVar('T')
+ModelT = TypeVar('ModelT')
Review Comment:
Python's native typing is preferred, beam.type_hints.TypeVariable is for
internal cases where we need to do serialization (and the former is converted
to the latter where needed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
