robertwb commented on PR #17762: URL: https://github.com/apache/beam/pull/17762#issuecomment-1142775314
> Sounds good. And I think the original intention of the transform in `api.py` was to provide a super clean interface that users could use without exposing the underlying logic. But I've also been wondering how useful it would really be since there's really no difference in how one would call `RunInference` if imported from `base.py` versus `api.py`: i.e. how many people would just call `RunInference` from `base.py` instead of from `api.py`? It'll probably lead to some unnecessary (though harmless) confusion. In that case, let's get rid of it. Confusion is often not harmless, especially for people trying to learn a bunch of other stuff too. On that note, any reason we have `pytorch.py` but `sklearn_inference.py`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
