yeandy commented on code in PR #17470: URL: https://github.com/apache/beam/pull/17470#discussion_r888353350
########## sdks/python/apache_beam/ml/inference/sklearn_inference.py: ########## @@ -42,8 +42,8 @@ class ModelFileType(enum.Enum): class SklearnInferenceRunner(InferenceRunner): - def run_inference(self, batch: List[numpy.ndarray], - model: Any) -> Iterable[PredictionResult]: + def run_inference(self, batch: List[numpy.ndarray], model: Any, + **kwargs) -> Iterable[PredictionResult]: Review Comment: Actually, I get this error ``` error: Signature of "run_inference" incompatible with supertype "InferenceRunner" ``` I think that happens when I take out `**kwargs`. Let me add it back and see if the error persists. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
