jayzhan211 opened a new issue, #10230:
URL: https://github.com/apache/datafusion/issues/10230
I think ideally the physical expr shouldn't be depending on
sql parser (for people who are not using SQL)
Though now I see that perhaps it is because AggregateFunction has a null
treatment flag on it 🤔 That might be a nice dependency to avoid
_Originally posted by @alamb in
https://github.com/apache/datafusion/pull/10214#discussion_r1579312800_
# The solution I expect
Replace `null_treatment` to bool. The logic should follow
```rust
let ignore_nulls = null_treatment
.unwrap_or(sqlparser::ast::NullTreatment::RespectNulls)
== NullTreatment::IgnoreNulls;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
