jayzhan211 commented on issue #10230: URL: https://github.com/apache/datafusion/issues/10230#issuecomment-2078407566
> > @alamb I would like to know if these API changes are fine to go. Specifically, WindowFunction and AggregateFunction are changed, but they will be easier to use. > > I think it is fine with me, but I see your point about the API change 🤔 We could potentially also add a new `NullTreatment` enum into DataFusion (rather than bool) to avoid the dependency If we introduce df version in common, or SQL crate. They both import sql_parser. Does that mean if anyone import the enum, they also get sql_parser 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
