tshauck commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1582524793
##########
core/src/execution/datafusion/expressions/scalar_funcs.rs:
##########
@@ -123,11 +126,10 @@ pub fn create_comet_physical_fun(
make_comet_scalar_udf!(spark_func_name, wrapped_func, without
data_type)
}
_ => {
- let fun = BuiltinScalarFunction::from_str(fun_name);
- if fun.is_err() {
- Ok(ScalarFunctionDefinition::UDF(registry.udf(fun_name)?))
+ if let Ok(fun) = BuiltinScalarFunction::from_str(fun_name) {
Review Comment:
Unrelated, but more idiomatic IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
