andygrove commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1583437769
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -1396,6 +1396,17 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde {
val optExpr = scalarExprToProto("atan2", leftExpr, rightExpr)
optExprWithInfo(optExpr, expr, left, right)
+ case e @ Unhex(child, failOnError) =>
Review Comment:
We need to use a shim approach. We currently have one folder with source for
spark-3.x. We should add additional folders as needed e.g. spark-3.3.x /
spark-3.4.x with any code that is specific to those versions.
I am happy to help with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
