andygrove commented on code in PR #351:
URL: https://github.com/apache/datafusion-comet/pull/351#discussion_r1585149771
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -43,99 +44,619 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
private val datePattern = "0123456789/" + whitespaceChars
private val timestampPattern = "0123456789/:T" + whitespaceChars
- ignore("cast long to short") {
- castTest(generateLongs, DataTypes.ShortType)
+ test("all valid cast combinations covered") {
+ val names = testNames
Review Comment:
Thanks. The nice thing is that this will tell us if Spark adds or removes
any supported cast operations in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
