andygrove commented on code in PR #351:
URL: https://github.com/apache/datafusion-comet/pull/351#discussion_r1585223410
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -176,28 +697,38 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
// cast() should throw exception on invalid inputs when ansi mode is
enabled
val df = data.withColumn("converted", col("a").cast(toType))
- val (expected, actual) = checkSparkThrows(df)
Review Comment:
This was improved to handle the case where no exceptions are thrown (some
cast operations are infallible).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
