alamb commented on issue #10074: URL: https://github.com/apache/datafusion/issues/10074#issuecomment-2092903258
> But, what if we allow datafusion-expr to import physical-expr-common 🤔 I see -- this makes sense. What I am worried about is that `physical-expr-common` would end up with all the code from `physical-expr` so while it has a different name it ends up being the same issue. I get the sense that part of the problem is that `first_value` and `last_value` are some of the most complex aggregate functions (as they can be used by window functions, and they have various other optimziations like reverse and sort aware) I wonder if we could try starting with some of the simpler and less used aggregates like `corr`, `stddev`, `covariance` that use fewer APIs and have fewer features. That might make it easier to incrementally discover how to structure the dependencies so we could extract the aggregates out of the core 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
