alamb opened a new pull request, #10369: URL: https://github.com/apache/datafusion/pull/10369
Draft as it builds on https://github.com/apache/datafusion/pull/10356 ## Which issue does this PR close? closes https://github.com/apache/datafusion/issues/10365 ## Rationale for this change recomputing the Schema can be expensive, so only do it when necessary ## What changes are included in this PR? 1. Update TypeCoercionRewriter to track when the expression is actually rewritten (via `Transformed::yes`) 2. Only recompute the schema when an expression was rewritten This is a big change change as it needs to is properly track when expressions were changed which required updating the entire expression rewrite ## Are these changes tested? Existing CI ## Are there any user-facing changes? No functional changes TODO performance tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
