parthchandra commented on issue #385: URL: https://github.com/apache/datafusion-comet/issues/385#issuecomment-2096477397
This https://github.com/apache/spark/pull/45488 adds the capability to get the extended explain info into Spark (which was the original goal). So one can call `EXPLAIN` in spark SQL or in the Spark UI to see why comet was not (fully) enabled. I should have added the log message you've added. That's a nice thing to have especially during development as it will hopefully encourage us to write user friendly messages :) The only reason for not having a Set is because there are some expressions/operators that may have multiple reasons for not being enabled and I wasn't sure how to assign a set to the tag value. Otherwise having the explain messages in a Set is very useful since it eliminates duplicates. (Note we do want an ordered set as we want to display leaf node messages first.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
