MohamedAbdeen21 commented on PR #10333: URL: https://github.com/apache/datafusion/pull/10333#issuecomment-2096549010
Thanks for the review @alamb. I was trying to implement it duckdb style with `#0`, `#1`, etc ... But as I'm not super familiar with the optimizer, I failed to do so, maybe someone can help. The biggest problem I found was that the rule is applied twice, meaning that we need a shared/global mapping of expr -> id between rule calls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
