Re: [PR] make common expression alias human-readable [datafusion]

[via GitHub]

peter-toth commented on code in PR #10333:
URL: https://github.com/apache/datafusion/pull/10333#discussion_r1595248066


##########
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##########
@@ -885,15 +876,15 @@ mod test {
         )?;
 
         let expected = vec![
-            (8, "{(SUM(a + Int32(1)) - AVG(c)) * Int32(2)|{Int32(2)}|{SUM(a + 
Int32(1)) - AVG(c)|{AVG(c)|{c}}|{SUM(a + Int32(1))|{a + 
Int32(1)|{Int32(1)}|{a}}}}}"),
-            (6, "{SUM(a + Int32(1)) - AVG(c)|{AVG(c)|{c}}|{SUM(a + 
Int32(1))|{a + Int32(1)|{Int32(1)}|{a}}}}"),
+            (8, "#{(SUM(a + Int32(1)) - AVG(c)) * Int32(2)}"),

Review Comment:
   `IdArray` shouldn't change by this PR. Actually, new fields can be added to 
the tuples but the identifier field should remain as it is.



##########
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##########
@@ -885,15 +876,15 @@ mod test {
         )?;
 
         let expected = vec![
-            (8, "{(SUM(a + Int32(1)) - AVG(c)) * Int32(2)|{Int32(2)}|{SUM(a + 
Int32(1)) - AVG(c)|{AVG(c)|{c}}|{SUM(a + Int32(1))|{a + 
Int32(1)|{Int32(1)}|{a}}}}}"),
-            (6, "{SUM(a + Int32(1)) - AVG(c)|{AVG(c)|{c}}|{SUM(a + 
Int32(1))|{a + Int32(1)|{Int32(1)}|{a}}}}"),
+            (8, "#{(SUM(a + Int32(1)) - AVG(c)) * Int32(2)}"),

Review Comment:
   `IdArray` shouldn't change in this PR. Actually, new fields can be added to 
the tuples but the identifier field should remain as it is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org