erratic-pattern commented on issue #9873: URL: https://github.com/apache/datafusion/issues/9873#issuecomment-2096768029
Actually it looks like `ExprSet` needs to be completely redesigned because it relies on cloning the `Expr`s. I've started [a branch](https://github.com/erratic-pattern/arrow-datafusion/commits/adam/no-copy-common-subexpr-elim/datafusion/optimizer/src/common_subexpr_eliminate.rs) for my work. Here is a [basic commit](https://github.com/erratic-pattern/arrow-datafusion/blob/d00261bdd892a36d98a1491f7fe3b6405daf39d0/datafusion/optimizer/src/common_subexpr_eliminate.rs#L405-L445) that simply swaps the existing code over to using the `rewrite` API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
