erratic-pattern commented on issue #9873: URL: https://github.com/apache/datafusion/issues/9873#issuecomment-2105306903
@peter-toth > the issue of String identifiers are explained in my PR. I have a solution for the issue, but https://github.com/apache/datafusion/pull/10396 is already huge and the implementation will be a bit tricky... I am thinking a `Hash` implementation for `Expr` would fix this problem, and is something I plan to work on soon. Would be interested to know what approach you think would work best. Having a `Hash` impl would also allow us to refactor other optimization rules which make heavy use of `display_name` to generate `HashMap` keys for `Expr`s -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
