viirya commented on code in PR #250:
URL: https://github.com/apache/datafusion-comet/pull/250#discussion_r1591475296
##########
spark/src/main/scala/org/apache/spark/sql/comet/plans/AliasAwareOutputExpression.scala:
##########
@@ -31,7 +31,8 @@ import org.apache.spark.sql.catalyst.trees.CurrentOrigin
trait AliasAwareOutputExpression extends SQLConfHelper {
// `SQLConf.EXPRESSION_PROJECTION_CANDIDATE_LIMIT` is Spark 3.4+ only.
// Use a default value for now.
- protected val aliasCandidateLimit = 100
+ protected val aliasCandidateLimit: Int =
+
conf.getConfString("spark.sql.optimizer.expressionProjectionCandidateLimit",
"100").toInt
Review Comment:
Some Spark tests tune this config. So we need to get the configured value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
